Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back ports getting tagged as latest on NPM + react-native-macos-init publish #1794

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Apr 20, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This PR fixes two changes:

  1. The react-native-macos-init publish job was missing a step to set up some tools, like node and ruby. This caused the pipeline to fail. This should be a relatively simple fix.

  2. Backports to 0.68-stable were getting tagged as "latest" on NPM. This is because our Publish pipeline has a variable latestStableBranch defined in its build settings, set to 0.68-stable. I thought I could override that locally in vars.yml, but that change didn't carry down to the 068-stable branch. Therefore, when a new change was published to 0.68-stable, it still thought that was the latest released and tagged it on NPM as such. To fix this, we can remove the variable from our yml, add back the note it's expected to be defined in the pipelines' build settings, and update the build settings. I don't have pipeline edit auth, so I'm asking @dannyvv to do so 🙂.

Changelog

[INTERNAL] [FIXED] - Fix back ports getting tagged as latest on NPM

Test Plan

CI should pass.

@Saadnajmi Saadnajmi requested a review from a team as a code owner April 20, 2023 06:59
@Saadnajmi Saadnajmi changed the title Fix react-native-macos-init publish Fix react-native-macos-init publish, move latestStableBranch variable out of xml Apr 20, 2023
@Saadnajmi Saadnajmi changed the title Fix react-native-macos-init publish, move latestStableBranch variable out of xml Fix react-native-macos-init publish, move latestStableBranch variable out of yml Apr 20, 2023
@Saadnajmi Saadnajmi changed the title Fix react-native-macos-init publish, move latestStableBranch variable out of yml Fix react-native-macos-init publish, and back ports getting tagged as latest on NPM Apr 20, 2023
@Saadnajmi Saadnajmi changed the title Fix react-native-macos-init publish, and back ports getting tagged as latest on NPM Fix back ports getting tagged as latest on NPM Apr 20, 2023
@Saadnajmi Saadnajmi changed the title Fix back ports getting tagged as latest on NPM Fix back ports getting tagged as latest on NPM + react-native-macos-init publish Apr 23, 2023
@Saadnajmi Saadnajmi merged commit 553d46e into microsoft:main Apr 24, 2023
@Saadnajmi Saadnajmi deleted the fix-init-publish branch August 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants