[Fabric] Use RCT_NEW_ARCH_ENABLED flag for enabling new arch #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwanton
changed the title
4 tasks
Saadnajmi
approved these changes
Apr 10, 2023
Saadnajmi
approved these changes
Apr 10, 2023
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Apr 11, 2023
…ft#1782) * Replace USE_FABRIC w/ RCT_NEW_ARCH_ENABLED flag for enabling new arch * Native CXX TM builds for macOS * Update RNTester podfile w/ correct flag --------- Co-authored-by: Shawn Dempsey <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Apr 11, 2023
…1783) * Replace USE_FABRIC w/ RCT_NEW_ARCH_ENABLED flag for enabling new arch * Native CXX TM builds for macOS * Update RNTester podfile w/ correct flag --------- Co-authored-by: Shawn Dempsey <[email protected]> Co-authored-by: Shawn Dempsey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
RCT_NEW_ARCH_ENABLED flag is what RN core uses for enabling the new architecture
Changelog
[GENERAL] [FIXED] - Use build flag from RN mobile for enabling new architecture
Test Plan
Fabric builds
RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --verbose