Refactor Publish pipeline (take 2) #1773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
#1771 merged prematurely... so here's take 2.
This change refactors both our NPM Publish and NPM Publish Dry Run jobs to be much more correct, readable, and actually work. Namely, there's a few big changes:
vars.yml
with nice names likeisMain
andisReleaseBranch
so it's a lot easier to reason aboutapple-job-publish
that contains most of the publish steps with a parameter for "build-type"isMain
andisReleaseBranch
), it's now very easy to reason if we're doing a nightly or a release build.All in all, very happy with this refactor :)
Changelog
[GENERAL] [FIXED] - Fix publish (attempt 2)
Test Plan
CI should pass