Fix rn-tester TextInput warning for missing image.source.uri #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an rn-tester only warning introduced in https://github.com/microsoft/react-native-macos/pull/1350/files as the image.source.uri should not be empty
Saadnajmi
approved these changes
Sep 13, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…ft#1434) This fixes an rn-tester only warning introduced in https://github.com/microsoft/react-native-macos/pull/1350/files as the image.source.uri should not be empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This fixes an rn-tester only warning introduced in #1350 as the image.source.uri should not be empty
Changelog
[macOS] [Fixed] - Fix rn-tester TextInput warning for missing image.source.uri
Test Plan
Before
After
Screen.Recording.2022-09-12.at.7.38.16.PM.mov