Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant podfile targets #1416

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

Saadnajmi
Copy link
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

These cocoapod targets are a relic of when this repo was closed source. Downstream we have a copy of these targets, and no longer need them in the open source repo

Changelog

[macOS] [Removed] - Remove redundant podfile targets

Test Plan

If this breaks stuff downstream, I'll back it out.

@Saadnajmi Saadnajmi requested a review from a team as a code owner September 2, 2022 06:38
@harrieshin
Copy link

"If this breaks stuff downstream, I'll back it out." how will u test it before you merge this pr?

@Saadnajmi
Copy link
Collaborator Author

"If this breaks stuff downstream, I'll back it out." how will u test it before you merge this pr?

I think I can check this downstream with a local yarn resolution + Nuget build. I'll report back...

@Saadnajmi
Copy link
Collaborator Author

Talked offline. This is one of those "This has to be merged to propagate downstream" kinda PRs, so we're just going to merge this now.

@Saadnajmi Saadnajmi merged commit aa96341 into microsoft:main Sep 8, 2022
@Saadnajmi Saadnajmi deleted the podfiles branch September 8, 2022 18:49
@Saadnajmi Saadnajmi mentioned this pull request Nov 3, 2022
4 tasks
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants