Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set accessibilityRole by default in Flatlist #1382

Merged
merged 36 commits into from
Aug 25, 2022

Conversation

chiuam
Copy link

@chiuam chiuam commented Aug 25, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Reverting 6ad34ef which broke Android. When updateViewProp gets called, the value "table" for the accessibilityRole prop is not recognized on Android. See the list of valid props for accessibilityRole here. iOS handles "table" as no-op since it's mapped to UIAccessibilityTraitNone.

Note: This implies that clients need to manually set the prop to get the accessibility effects.

Changelog

[Fixed] [macOS] - Don't set accessibilityRole by default in Flatlist

Test Plan

  1. Flatlist VO works as expected on macOS.
  2. Flatlist boots on iOS.

chiuam and others added 30 commits May 19, 2022 17:24
@chiuam chiuam requested a review from a team as a code owner August 25, 2022 18:56
@chiuam chiuam merged commit 0c88572 into microsoft:main Aug 25, 2022
@chiuam chiuam deleted the flatlist-accessibility branch August 25, 2022 20:12
chiuam added a commit to chiuam/react-native-macos that referenced this pull request Aug 25, 2022
chiuam added a commit to chiuam/react-native-macos that referenced this pull request Aug 25, 2022
chiuam added a commit to chiuam/react-native-macos that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants