RNTester: Only show the Flatlist keyboard navigation switch on macOS #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Aug 25, 2022
harrieshin
reviewed
Aug 25, 2022
chiuam
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
We show the Switch to enable Keyboard Navigation on all platforms. Let's make it only macOS, the only platform we validated. Also, let's change some styles used only by the test app to have a fallback non-platform color if we're not on macOS, should someone manage to enable the switch anyway.
Changelog
[macOS] [Fixed] - Only show the Flatlist keyboard navigation switch on macOS
Test Plan
Switch no longer shows up on iOS
If I force it to be true on iOS, the test app isn't too broken:
Screen.Recording.2022-08-25.at.11.32.36.AM.mov