Fix handling of keyDown/keyUp events by TextInput #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
force-pushed
the
keyDownKeyUpEvents
branch
from
fbffe69 to
367a6a3
Compare
christophpurrer
force-pushed
the
keyDownKeyUpEvents
branch
from
367a6a3 to
71ca513
Compare
Saadnajmi
reviewed
Aug 11, 2022
christophpurrer
force-pushed
the
keyDownKeyUpEvents
branch
from
71ca513 to
65bd3ff
Compare
Saadnajmi
reviewed
Aug 23, 2022
christophpurrer
force-pushed
the
keyDownKeyUpEvents
branch
from
65bd3ff to
a3cb6fd
Compare
This extends the ability to intercept `keyDown` and `keyUp` events to `TextInput`. We need this for the ability to insert newlines when holding shift in chat, along with support arrow up/down from the search input.
christophpurrer
force-pushed
the
keyDownKeyUpEvents
branch
from
a3cb6fd to
a3bd5ff
Compare
christophpurrer
commented
Aug 27, 2022
Saadnajmi
reviewed
Sep 7, 2022
|
One thing I'm a little confused on: For both singleLine and multiLine TextInput, the I tried to confirm my theory (calling |
Saadnajmi
approved these changes
Sep 7, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
This extends the ability to intercept `keyDown` and `keyUp` events to `TextInput`. We need this for the ability to insert newlines when holding shift in chat, along with support arrow up/down from the search input. Co-authored-by: Scott Kyle <[email protected]> Co-authored-by: Saad Najmi <[email protected]>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
This extends the ability to intercept `keyDown` and `keyUp` events to `TextInput`. We need this for the ability to insert newlines when holding shift in chat, along with support arrow up/down from the search input. Co-authored-by: Scott Kyle <[email protected]> Co-authored-by: Saad Najmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
This extends the ability to intercept
keyDownandkeyUpevents toTextInput.We need this for the ability to insert newlines when holding shift in chat, along with support arrow up/down from the search input.
Question:
Will the change here cause a conflict with #1044 ?
Changelog
[macOS] [Added] - Fix handling of keyDown/keyUp events by TextInput
Test Plan
I have updated the demo for the last test plan
Screen.Recording.2022-08-26.at.3.23.05.PM.mov
Original Test Plan
Using the added rn-tester sample ... capturing keyEvents via keyCastr.app
Before
before.mov
After
after.mov