Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more stale folders/files/changes #1337

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Aug 7, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Remove some more file diffs between RN Core @ 0.68.2 and RN macOS @ main

  • v8-docker folder, which doesn't exist in RN Core and seems to be a relic of when this repo was closed source.
  • A merge artifact.
  • A remnant of `acceptsKeyboardFocus
  • Some scripts related to SDX Platform that also seem outdated
  • Somer random newlines that are somehow missing.

Reduces the diffs between our main and RN Core's 0.68-stable from 841 to 820
facebook/react-native@v0.68.2...Saadnajmi:react-native-macos:remove-more

Changelog

[Internal] [Removed] - Remove more stale folders and files

Test Plan

CI should pass

@Saadnajmi Saadnajmi requested a review from a team as a code owner August 7, 2022 20:36
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3f8071d
Branch: main

@Saadnajmi Saadnajmi changed the title Remove another stale folder + stale merge file Remove more stale folders/files/changes Aug 8, 2022
@Saadnajmi Saadnajmi merged commit 90a371a into microsoft:main Aug 8, 2022
@Saadnajmi Saadnajmi deleted the remove-more branch August 8, 2022 19:22
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
* Delete more stuff

* Remove some stale looking SDX platform scripts

* Remove remnant of `acceptsKeyboardFocus`

* Add back some missing newlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants