Match package.json dependencies with RN Core + prettier #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
commented
Aug 5, 2022
Base commit: 4899f8c |
Saadnajmi
force-pushed
the
match-dependencies
branch
from
9bc45fd to
cd436da
Compare
Saadnajmi
force-pushed
the
match-dependencies
branch
from
a2cd918 to
0ddeed7
Compare
Saadnajmi
changed the title
harrieshin
approved these changes
Aug 5, 2022
Saadnajmi
commented
Aug 5, 2022
4 tasks
shivenmian
approved these changes
Aug 5, 2022
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 7, 2022
Like ```yarn prettier --fix``` for JS code, we should also run ```yarn format``` for native code. Ideally this would also run as CI job. I did some quick tests, and the result seems identical to the one used in facebook/react-native Note: We need to make sure to have the same repo-config which has been (partially) addressed in microsoft#1333
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 7, 2022
Like ```yarn prettier --fix``` for JS code, we should also run ```yarn format``` for native code. Ideally this would also run as CI job. See also: https://reactnative.dev/contributing/how-to-contribute-code#development-workflow I did some quick tests, and the result seems identical to the one used in facebook/react-native Note: We need to make sure to have the same repo-config which has been (partially) addressed in microsoft#1333
4 tasks
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 7, 2022
Like ```yarn prettier --fix``` for JS code, we should also run ```yarn format``` for native code. Ideally this would also run as CI job. See also: https://reactnative.dev/contributing/how-to-contribute-code#development-workflow I did some quick tests, and the result seems identical to the one used in facebook/react-native Note: We need to make sure to have the same repo-config which has been (partially) addressed in microsoft#1333
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 7, 2022
Like ```yarn prettier --fix``` for JS code, we should also run ```yarn format``` for native code. Ideally this would also run as CI job. See also: https://reactnative.dev/contributing/how-to-contribute-code#development-workflow I did some quick tests, and the result seems identical to the one used in facebook/react-native Note: We need to make sure to have the same repo-config which has been (partially) addressed in microsoft#1333
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 7, 2022
Like ```yarn prettier --fix``` for JS code, we should also run ```yarn format``` for native code. Ideally this would also run as CI job. See also: https://reactnative.dev/contributing/how-to-contribute-code#development-workflow I did some quick tests, and the result seems identical to the one used in facebook/react-native Note: We need to make sure to have the same repo-config which has been (partially) addressed in microsoft#1333
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
* update package.json files and yarn lock * yarn prettier --fix * Fix remaining yarn lint issues * Fix integration CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Addresses #1326
It seems some of our dependencies got messed up during a merge. I went to RN Core's
package.jsonfiles atrootandrepo-configand just straight copied the dependencies and rer-ranyarn install. This should fix / replace #1327 .If we compare this branch against RN Core's 0.68-stable, we are now down from 2,500 files changed to ~840 :)
Changelog
[Internal] [Fixed] - Match package.json dependencies with RN Core at 0.68-stable
Test Plan
CI should pass.