forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TextInput setting insertionPointColor #1321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Aug 3, 2022
We should not be setting the insertionPointColor by default. Let the OS do its thing. Later we can consider exposing a prop for this but the default should be to not set it.
da30fa2
to
1de6fd3
Compare
@Saadnajmi > Is I just ran it locally and I get the same error as in the failed ci/circleci: test_ios_unit_hermes job
I have the same problem in #1322 |
chiuam
approved these changes
Aug 5, 2022
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 9, 2022
# Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 9, 2022
# Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 10, 2022
# Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m # Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
# Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
# Conflicts: # Libraries/Text/TextInput/Multiline/RCTUITextView.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
We should not be setting the insertionPointColor by default.
Let the OS do its thing.
Later we can consider exposing a prop for this but the default should be to not set it.
Changelog
[macOS] [Changed] - Remove TextInput setting insertionPointColor
Test Plan
Setting a purple
selectionColor
on the texInput fieldsBefore
After