forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass grammarCheck to text input views for Mac #1293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiuam
approved these changes
Jul 26, 2022
946930d
to
7ca7548
Compare
Similar to microsoft#1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
7ca7548
to
12fca25
Compare
christophpurrer
pushed a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Aug 10, 2022
# Conflicts: # Libraries/Components/TextInput/TextInput.js
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1293 Pull Request resolved: facebook#37384 Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`. Reviewed By: yungsters Differential Revision: D45772554 fbshipit-source-id: 7c9f475de6f2568927d1c451e8de0dda89395f61
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1293 Pull Request resolved: facebook#37384 Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`. Reviewed By: yungsters Differential Revision: D45772554 fbshipit-source-id: c5dbfbd6604caf3f7352c69d120a91e056185c85
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1293 Pull Request resolved: facebook#37384 Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`. Reviewed By: yungsters Differential Revision: D45772554 fbshipit-source-id: b2b4bcf90129013141b151efc9c878c8eb91c3b0
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
May 11, 2023
Summary: X-link: facebook/yoga#1293 Pull Request resolved: facebook#37384 Gets the project mostly clean of `-Wunused-parameter`, part of `-Wextra`. Reviewed By: yungsters Differential Revision: D45772554 fbshipit-source-id: fbb57752c2be50ad9c0ffe5627a6a67391ff6a83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Similar to #1292 this adds a macOS only property to toggle grammarCheck on RCTUITextField
Changelog
[macOS] [Added] - Pass grammarCheck to text input views for Mac
Test Plan
Using this sample
Before
before.mov
After
after.mov