Single line TextInput fixes (prevent newLines, support horizontal overflow) #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
reviewed
Jul 25, 2022
This diff fixes 2 bugs with TextInput: 1. The default macOS behavior for single line text inputs is that they scroll horizontally when they overflow. react-native-macOS was making it paginate instead 2. Single line text input allowed pressing Ctrl+Enter to insert a new line
christophpurrer
force-pushed
the
singleLineTextInputFixes
branch
from
1eedb23 to
0031297
Compare
chiuam
approved these changes
Jul 27, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This diff fixes 2 bugs with TextInput:
Changelog
[macOS] [Fixe] - Single line TextInput fixes (prevent newLines, support horizontal overflow)
Test Plan
Before
CTRL + W > adds new line
Text paginates
before.mov
After
No new lines
Text overflows
after.mov