Fix nested Text components not inheriting foreground color from parent

[christophpurrer]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

This seems to due RN Mac commits that fix text colors for dark mode:

• 8ed55a8
• 731a535

It works on iOS, web .... so it should behave the same on macOS as well

Changelog

[macOS] [Fixed] - Fix nested Text components not inheriting foreground color from parent

Test Plan

Before

After

iOS - as reference

[Saadnajmi]

OK, so I looked more into this. I was wondering why RN macOS diverged from RN Core on foreground color for Text. Upon testing, I realize that RN Core has a bug that we fixed in RN macOS.

The iPhone simulator on the left and macOS app in the middle are running with React Native macOS. They properly handle Text in Dark mode. The iPhone simulator on the right is RN Core on main, and has the incorrect color (black text on dark grey background).

[Saadnajmi]

Between this PR and the 2 commits mentioned, there's a candidate for an RN Core upstream fix. I guess we can further discuss how we should track those / the strategy for how we push those / who will make the fix. I believe you mentioned there are more commits y'all have that could also be RN Core upstream fixes, so I feel it's worth chatting about :)

[christophpurrer]

@Saadnajmi
So it seems we have 2 issues here:
1 rn-macOS doesn't correctly support inner text field colors
2 rn-core/iOS doesn't correctly support background colors

1 is fixed here. It 2 is still a problem I am gonna fix it as well ;-)