Turn on focus ring for multiline textinput #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Jul 22, 2022
Saadnajmi
reviewed
Jul 22, 2022
Saadnajmi
approved these changes
Jul 22, 2022
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Jul 25, 2022
chiuam
added a commit
that referenced
this pull request
Jul 25, 2022
chiuam
added a commit
to chiuam/react-native-macos
that referenced
this pull request
Jul 25, 2022
chiuam
added a commit
that referenced
this pull request
Jul 25, 2022
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jul 28, 2022
This fixes a regression introduced in microsoft#1276 We should respect the boolean flag sent from the JS to enable/disable the focusRing
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
This change addresses #1251. NSTextView doesn't have focus ring enabled by default so let's turn it on for better accessibility experience.
Note: Since we allow tabs as valid entry, we can press ctrl+tab to move to the next focusable element / ctrl+tab+shift to the previous focusable element.
Changelog
[macOS] [Fixed] - Turn on focus ring for multiline TextInput
Test Plan
Before: Keyboard navigation works fine just no focus ring on multiline text input.
Before.-.Multiline.TextInput.mov
After: Multiline text input focus ring works as expected.
After.-.Multiline.TextInput.mov