Allow scrollResponderZoomTo() on macOS

[christophpurrer]

Please select one of the following

• I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
• I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
• I am making a fix / change for the macOS implementation of react-native
• I am making a change required for Microsoft usage of react-native

Summary

Already works on macOS (as it does on iOS).
Doesn't work on Android or Windows.

Changelog

[macOS] [Changed] - Allow scrollResponderZoomTo() on macOS

Test Plan

I have used the following sample in rn-tester in ScrollViewExample.js

const HorizontalScrollView = (props: {direction: 'ltr' | 'rtl'}) => {
  const {direction} = props;
  const scrollRef = React.useRef<?React.ElementRef<typeof ScrollView>>();
  const [scale, setScale] = useState(20);
  const [coord, setCoord] = useState(0);
  const title = direction === 'ltr' ? 'LTR Layout' : 'RTL Layout';
  return (
    <View style={{direction}}>
      <Text style={styles.text}>{title}</Text>
      <ScrollView
        ref={scrollRef}
        automaticallyAdjustContentInsets={false}
        horizontal={true}
        style={[styles.scrollView, styles.horizontalScrollView]}
        testID={'scroll_horizontal'}
      >
        {ITEMS.map(createItemRow)}
      </ScrollView>
      <Button
        label="Scroll to start"
        onPress={() => {
                setScale(scale + 20);
                setCoord(coord + 1);
                scrollRef.current?.scrollResponderZoomTo({
                  x: coord,
                  y: coord,
                  width: scale,
                  height: scale,
                  animated: true,
                });
          //nullthrows(scrollRef.current).scrollTo({x: 0});
        }}
        testID={'scroll_to_start_button'}
      />
      <Button
        label="Scroll to end"
        onPress={() => {
          nullthrows(scrollRef.current).scrollToEnd({animated: true});
        }}
        testID={'scroll_to_end_button'}
      />
    </View>
  );
};

Screen.Recording.2022-07-21.at.12.25.39.PM.mov

Also used at Meta for Messenger Desktop.

[analysis-bot]

Code analysis results:

• eslint found some issues. Run yarn lint --fix to automatically fix problems.

[harrieshin]

@Saadnajmi / @amgleitman : not sure why Apple PR failed with the following error. can you take a look, please?
RCTBundleURLProviderTests ✗ testBundleURL, ((URL) equal to (localhostBundleURL())) failed: ("file:///Applications/Xcode_13.3.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Agents/main.jsbundle") is not equal to ("[http://localhost:8081/test.jsbundle.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.apple.dt.xctest.tool"](http://localhost:8081/test.jsbundle.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.apple.dt.xctest.tool%22)) ✗ testBundleURL, ((URL) equal to (localhostBundleURL())) failed: ("file:///Applications/Xcode_13.3.1.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Agents/main.jsbundle") is not equal to ("[http://localhost:8081/test.jsbundle.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.apple.dt.xctest.tool"](http://localhost:8081/test.jsbundle.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=com.apple.dt.xctest.tool%22))

[Saadnajmi]

@harrieshin intermittent failure. I reran and we're good now

[christophpurrer]

Great!