Import OCMock for RNTester macOS as a pod #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrieshin
approved these changes
Jul 13, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 6, 2023
Summary: This is a change we have implemented in React Native macOS that I am now upstreaming: microsoft#1257 The library `ocMock` is currently imported as a checked in binary by RN-Tester to help run unit tests on iOS. That binary is only compiled for x86 on macOS, which meant we could not run tests on M1 / M2 Macs. Switching it so that we import from source as a pod should make maintenance easier for both iOS and macOS! :) Original change notes: >Previously, we've been unable to test RNTester for macOS on an M1 machine. This is because we were using a framework that was prebuilt for Intel architecture, so the test components would fail to build. > > The fix is to build OCMock from source directly instead of using a prebuilt version. > > This is only necessary on macOS. The iOS version is already built for ARM architecture, as iOS devices have been running exclusively on ARM for a while now. ## Changelog [INTERNAL] [CHANGED] - Import OCMock as a pod Pull Request resolved: #36239 Test Plan: CI should pass as it did before. Reviewed By: dmytrorykun Differential Revision: D43732219 Pulled By: cipolleschi fbshipit-source-id: 028b5a7f384042145bf1966c8c2730d7437940ec
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This is a change we have implemented in React Native macOS that I am now upstreaming: microsoft#1257 The library `ocMock` is currently imported as a checked in binary by RN-Tester to help run unit tests on iOS. That binary is only compiled for x86 on macOS, which meant we could not run tests on M1 / M2 Macs. Switching it so that we import from source as a pod should make maintenance easier for both iOS and macOS! :) Original change notes: >Previously, we've been unable to test RNTester for macOS on an M1 machine. This is because we were using a framework that was prebuilt for Intel architecture, so the test components would fail to build. > > The fix is to build OCMock from source directly instead of using a prebuilt version. > > This is only necessary on macOS. The iOS version is already built for ARM architecture, as iOS devices have been running exclusively on ARM for a while now. ## Changelog [INTERNAL] [CHANGED] - Import OCMock as a pod Pull Request resolved: facebook#36239 Test Plan: CI should pass as it did before. Reviewed By: dmytrorykun Differential Revision: D43732219 Pulled By: cipolleschi fbshipit-source-id: 028b5a7f384042145bf1966c8c2730d7437940ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Previously, we've been unable to test RNTester for macOS on an M1 machine. This is because we were using a framework that was prebuilt for Intel architecture, so the test components would fail to build.
The fix is to build OCMock from source directly instead of using a prebuilt version.
This is only necessary on macOS. The iOS version is already built for ARM architecture, as iOS devices have been running exclusively on ARM for a while now.
Test Plan
We can build and test RNTester on macOS.