Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window jitters when resizing #422

Closed
elicwhite opened this issue May 27, 2020 · 1 comment
Closed

Window jitters when resizing #422

elicwhite opened this issue May 27, 2020 · 1 comment
Labels
Needs: Triage 🔍 Partner: Facebook

Comments

@elicwhite
Copy link
Collaborator

Environment

  1. react-native -v:
  2. npm ls react-native-macos: 0.61.38
  3. node -v:
  4. npm -v:
  5. yarn --version:
  6. xcodebuild -version:

Issue

When resizing a window with a ScrollView in it the contents constantly rubberband.

jumplist

Steps to Reproduce

  1. Open RNTester (or any app screen with a scrollview)
  2. Resize
  3. 😭
@ghost ghost added the Needs: Triage 🔍 label May 27, 2020
@elicwhite elicwhite changed the title Window Resize Jitter Window jitters when resizing May 27, 2020
@elicwhite elicwhite mentioned this issue Jun 2, 2020
Closed
@elicwhite
Copy link
Collaborator Author

Duplicate of #322

@elicwhite elicwhite marked this as a duplicate of #322 Jun 2, 2020
@tido64 tido64 mentioned this issue Jun 18, 2020
Closed
christophpurrer pushed a commit to christophpurrer/react-native-macos that referenced this issue Aug 2, 2022
@appden @christophpurrer
Revert "Alleviate excessive layout jittering when resizing window (mi…
c31baa6 
…crosoft#439)"

This change reverts microsoft#459 - but still tries to address the original issues:
- microsoft#422
- microsoft#322

This also addresses an issue when programmatically resizing windows where the RCTRootContentView may end up at the wrong size because an in-flight layout gets resolved after the resize on the main thread.
We now keep sync dispatch on the shadow queue for live resizing windows (to prevent tearing) but also dispatch async (as done on iOS) so the latest new size is sure to win.
The block has a check to bail if the size doesn't change, so this isn't a perf drain running the block twice.
@christophpurrer christophpurrer mentioned this issue Aug 2, 2022
Merged
4 tasks
christophpurrer pushed a commit to christophpurrer/react-native-macos that referenced this issue Aug 2, 2022
@appden @christophpurrer
Revert "Alleviate excessive layout jittering when resizing window (mi…
cb1f147 
…crosoft#439)"

This change reverts microsoft#459 - but still tries to address the original issues:
- microsoft#422
- microsoft#322

This also addresses an issue when programmatically resizing windows where the RCTRootContentView may end up at the wrong size because an in-flight layout gets resolved after the resize on the main thread.
We now keep sync dispatch on the shadow queue for live resizing windows (to prevent tearing) but also dispatch async (as done on iOS) so the latest new size is sure to win.
The block has a check to bail if the size doesn't change, so this isn't a perf drain running the block twice.
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this issue Aug 4, 2022
@christophpurrer @appden
Revert "Alleviate excessive layout jittering when resizing window (mi…
e6482e0 
…crosoft#439)" (microsoft#1318)

This change reverts microsoft#459 - but still tries to address the original issues:
- microsoft#422
- microsoft#322

This also addresses an issue when programmatically resizing windows where the RCTRootContentView may end up at the wrong size because an in-flight layout gets resolved after the resize on the main thread.
We now keep sync dispatch on the shadow queue for live resizing windows (to prevent tearing) but also dispatch async (as done on iOS) so the latest new size is sure to win.
The block has a check to bail if the size doesn't change, so this isn't a perf drain running the block twice.

Co-authored-by: Scott Kyle <[email protected]>
shwanton pushed a commit to shwanton/react-native-macos that referenced this issue Feb 13, 2023
@christophpurrer @appden
Revert "Alleviate excessive layout jittering when resizing window (mi…
dc276cd 
…crosoft#439)" (microsoft#1318)

This change reverts microsoft#459 - but still tries to address the original issues:
- microsoft#422
- microsoft#322

This also addresses an issue when programmatically resizing windows where the RCTRootContentView may end up at the wrong size because an in-flight layout gets resolved after the resize on the main thread.
We now keep sync dispatch on the shadow queue for live resizing windows (to prevent tearing) but also dispatch async (as done on iOS) so the latest new size is sure to win.
The block has a check to bail if the size doesn't change, so this isn't a perf drain running the block twice.

Co-authored-by: Scott Kyle <[email protected]>
shwanton pushed a commit to shwanton/react-native-macos that referenced this issue Mar 10, 2023
@christophpurrer @appden
Revert "Alleviate excessive layout jittering when resizing window (mi…
0840ba9 
…crosoft#439)" (microsoft#1318)

This change reverts microsoft#459 - but still tries to address the original issues:
- microsoft#422
- microsoft#322

This also addresses an issue when programmatically resizing windows where the RCTRootContentView may end up at the wrong size because an in-flight layout gets resolved after the resize on the main thread.
We now keep sync dispatch on the shadow queue for live resizing windows (to prevent tearing) but also dispatch async (as done on iOS) so the latest new size is sure to win.
The block has a check to bail if the size doesn't change, so this isn't a perf drain running the block twice.

Co-authored-by: Scott Kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Triage 🔍 Partner: Facebook
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elicwhite