-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #251 #269
issue #251 #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The identifiers for the new classes you created are not OBO compliant. You cannot use UUIDs. We can work through the required Protege settings to create proper IDs.
You cannot change the definitions of IAO classes. We need to check that all IAO is being imported and that there is no longer any copy and paste into omrse-edit.owl.
Apologies, I take back the bit about IAO class definitions. We were going to do the obsoletion of the old stuff in this PR, or a separate one? |
## Primary Changes ### The following changes were made with proper Protege settings applied to PR #269 branch omrse-edit.owl file: _*Changes under this section are restricted to the addition of the requested and approved new terms, ref. issue #251; see screencaptures, labeled A-G, of each item below_ 1. Recreation of class 'social category data item' (OMRSE:00000292) [A] 2. Recreation of class 'racial category data item' as child class of 'social category data item' (OMRSE:00000295) [B] 3. Recreation of class 'gender category data item' as child class of 'social category data item' (OMRSE:00000294) [C] 4. Recreation of class 'ethnic category data item' as child class of 'social category data item' (OMRSE:00000293) [D] ### For adequate axiom support of new classes (above), the following were required: 1. Recreation of class 'gender category' (OMRSE:00000291) [E] 2. Recreation of class 'gender categorization scheme' (OMRSE:00000290) [F] 3. Creation of class 'gender identity' (OMRSE:00000296) [G] ## Screencaptures **A**  **B**  **C**  **D**  **E**  **F**  **G** 
Primary ChangesThe following changes were made with proper Protege settings applied to PR #269 branch omrse-edit.owl file:*Changes under this section are restricted to the addition of the requested and approved new terms, ref. issue #251; see screencaptures, labeled A-G, of each item below
For adequate axiom support of new classes (above), the following were required:
Screencaptures |
…s:contributor is enforced by ODK to be an IRI, so you have to convert the ORCID to an IRI/URL �
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I updated the contributor annotations. We should use dcterms from now on, and dcterms:contributor requires an IRI so you need to use the URL form of ORCID (note that URL subClassOf IRI).
All changes agreed upon during OMRSE meeting, 5 March 2025, including all four new terms proposed by @CDowland (issue #251)