Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #251 #269

Merged
merged 3 commits into from
Mar 25, 2025
Merged

issue #251 #269

merged 3 commits into from
Mar 25, 2025

Conversation

dexink
Copy link
Collaborator

@dexink dexink commented Mar 5, 2025

All changes agreed upon during OMRSE meeting, 5 March 2025, including all four new terms proposed by @CDowland (issue #251)

All changes agreed upon during OMRSE meeting, 5 March 2025, including all four new terms proposed by @CDowland (issue #251 )
Copy link
Contributor

@hoganwr hoganwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The identifiers for the new classes you created are not OBO compliant. You cannot use UUIDs. We can work through the required Protege settings to create proper IDs.

You cannot change the definitions of IAO classes. We need to check that all IAO is being imported and that there is no longer any copy and paste into omrse-edit.owl.

@hoganwr
Copy link
Contributor

hoganwr commented Mar 17, 2025

Apologies, I take back the bit about IAO class definitions.

We were going to do the obsoletion of the old stuff in this PR, or a separate one?

## Primary Changes
### The following changes were made with proper Protege settings applied to PR #269 branch omrse-edit.owl file:
_*Changes under this section are restricted to the addition of the requested and approved new terms, ref. issue #251; see screencaptures, labeled A-G, of each item below_

1. Recreation of class 'social category data item' (OMRSE:00000292) [A]
2. Recreation of class 'racial category data item' as child class of 'social category data item' (OMRSE:00000295) [B]
3. Recreation of class 'gender category data item' as child class of 'social category data item' (OMRSE:00000294) [C]
4. Recreation of class 'ethnic category data item' as child class of 'social category data item' (OMRSE:00000293) [D]

### For adequate axiom support of new classes (above), the following were required:

1. Recreation of class 'gender category' (OMRSE:00000291) [E]
2. Recreation of class 'gender categorization scheme' (OMRSE:00000290) [F]
3. Creation of class 'gender identity' (OMRSE:00000296) [G]

## Screencaptures
**A**
![Screenshot 2025-03-25 at 9 19 01 AM](https://github.com/user-attachments/assets/ba16bf30-54bd-4b0b-8fb7-6212e3c9d116)

**B**
![Screenshot 2025-03-25 at 9 19 40 AM](https://github.com/user-attachments/assets/299de655-0042-4193-9834-f5d06ebca4c4)

**C**
![Screenshot 2025-03-25 at 9 20 09 AM](https://github.com/user-attachments/assets/15bbb1ce-c8eb-4667-8203-e3793d8e5746)

**D**
![Screenshot 2025-03-25 at 9 20 46 AM](https://github.com/user-attachments/assets/f0ad0935-82ef-4c71-9e6d-a1d8a146c5c8)

**E**
![Screenshot 2025-03-25 at 9 21 14 AM](https://github.com/user-attachments/assets/27fd7cb3-67c0-4102-b611-9965b78cfc4a)

**F**
![Screenshot 2025-03-25 at 9 21 50 AM](https://github.com/user-attachments/assets/9ba2e6f8-9e65-4f9c-b410-9d32698b23e3)

**G**
![Screenshot 2025-03-25 at 9 22 18 AM](https://github.com/user-attachments/assets/ebaeec75-9cad-4f6b-b495-9af62ada9b2a)
@dexink
Copy link
Collaborator Author

dexink commented Mar 25, 2025

Primary Changes

The following changes were made with proper Protege settings applied to PR #269 branch omrse-edit.owl file:

*Changes under this section are restricted to the addition of the requested and approved new terms, ref. issue #251; see screencaptures, labeled A-G, of each item below

  1. Recreation of class 'social category data item' (OMRSE:00000292) [A]
  2. Recreation of class 'racial category data item' as child class of 'social category data item' (OMRSE:00000295) [B]
  3. Recreation of class 'gender category data item' as child class of 'social category data item' (OMRSE:00000294) [C]
  4. Recreation of class 'ethnic category data item' as child class of 'social category data item' (OMRSE:00000293) [D]

For adequate axiom support of new classes (above), the following were required:

  1. Recreation of class 'gender category' (OMRSE:00000291) [E]
  2. Recreation of class 'gender categorization scheme' (OMRSE:00000290) [F]
  3. Creation of class 'gender identity' (OMRSE:00000296) [G]

Screencaptures

A
Screenshot 2025-03-25 at 9 19 01 AM

B
Screenshot 2025-03-25 at 9 19 40 AM

C
Screenshot 2025-03-25 at 9 20 09 AM

D
Screenshot 2025-03-25 at 9 20 46 AM

E
Screenshot 2025-03-25 at 9 21 14 AM

F
Screenshot 2025-03-25 at 9 21 50 AM

G
Screenshot 2025-03-25 at 9 22 18 AM

…s:contributor is enforced by ODK to be an IRI, so you have to convert the ORCID to an IRI/URL �
Copy link
Contributor

@hoganwr hoganwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I updated the contributor annotations. We should use dcterms from now on, and dcterms:contributor requires an IRI so you need to use the URL form of ORCID (note that URL subClassOf IRI).

@dexink dexink merged commit 616acc7 into main Mar 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants