Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mautic/core-lib version constraint #14748

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Update mautic/core-lib version constraint #14748

merged 2 commits into from
Mar 25, 2025

Conversation

matbcvo
Copy link
Contributor

@matbcvo matbcvo commented Mar 17, 2025 •
edited
Loading

Q A
Bug fix? (use the a.b branch) ❌
New feature/enhancement? (use the a.x branch) ❌
Deprecations? ❌
BC breaks? (use the c.x branch) ❌
Automated tests included? ❌
Related user documentation PR URL mautic/user-documentation#...
Related developer documentation PR URL mautic/developer-documentation-new#...
Issue(s) addressed Fixes #...

Description

This PR updates the mautic/core-lib version constraint to support versions >=7.0 && <8.0.
The current constraint, ^6.0, allows versions >=6.0 && <7.0, which means it does not support 7.x.

📋 Steps to test this PR:

  1. Check if CI tests passed

@matbcvo matbcvo force-pushed the update-core-lib-version branch from 539489b to 4ae91e7 Compare March 17, 2025 15:42
@matbcvo matbcvo force-pushed the update-core-lib-version branch from 4ae91e7 to b970539 Compare March 17, 2025 15:43
@matbcvo matbcvo added the composer Any bugs or PRs relating to composer label Mar 17, 2025
@matbcvo matbcvo marked this pull request as ready for review March 17, 2025 15:50
@matbcvo matbcvo added this to the 7.0.0-alpha milestone Mar 17, 2025
escopecz
escopecz approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@escopecz escopecz added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged code-review-passed PRs which have passed code review labels Mar 19, 2025
@matbcvo matbcvo mentioned this pull request Mar 20, 2025
Merged
andersonjeccel
andersonjeccel approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@andersonjeccel andersonjeccel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems functional

@andersonjeccel andersonjeccel added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged user-testing-passed PRs which have been successfully tested by the required number of people. and removed pending-test-confirmation PR's that require one test before they can be merged labels Mar 25, 2025
@escopecz escopecz merged commit 67e3cee into mautic:7.x Mar 25, 2025
16 checks passed
@matbcvo matbcvo deleted the update-core-lib-version branch March 25, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escopecz escopecz escopecz approved these changes

@andersonjeccel andersonjeccel andersonjeccel approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs code-review-passed PRs which have passed code review composer Any bugs or PRs relating to composer ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged user-testing-passed PRs which have been successfully tested by the required number of people.
Projects
Open Source Fridays
Status: 🥳 Done
Milestone
7.0.0-alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@matbcvo @escopecz @andersonjeccel