This repository was archived by the owner on Mar 10, 2024. It is now read-only.
Fix for IE9 Double Click and Missed Dropzone #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the addition of the .dndDraggingSource class is in a $timeout, there is no guarantee that this class exists at the time of removal. In IE9 this appears to be an issue because the the drag operation are event loop blocking.
|
Thanks for your PR, the solution makes a lot of sense to me. I merged it to the dev branch, but haven't actually gotten around to test it in IE. Will merge to master once I did that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the addition of the .dndDraggingSource class is in a $timeout,
there is no guarantee that this class exists at the time of removal.
In IE9 this appears to be an issue because the the drag operation
are event loop blocking.
Potential fix for #21.
I didn't minify code/package anything, I'll leave that a release. Also, as a side note that one might consider: while the timeout might be necessary, perhaps it might be worth just using a regular setTimeout instead of $timeout for the add and removal of this class. There's no need to fire a potential $digest for this.