Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laji-api-client person & lang population & http method as method name #764

Open
wants to merge 8 commits into
base: development
Choose a base branch
from

Conversation

olzraiti
Copy link
Member

@olzraiti olzraiti commented Mar 20, 2025

  1. Replaces fetch with methods get(), post(), put(), delete() which make the signature more intuitive to use.
  2. Automatically populates lang and personToken into the query params, simplifying client usage and narrowing the surface for bugs.
  3. Adds API-Version header to all requests.

@olzraiti olzraiti requested a review from Blodir March 20, 2025 16:14
@olzraiti
Copy link
Member Author

I moved controlling the personToken & lang to outside the api service (app.component)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant