Apply links to browse taxon -page [closes #696] #755
Conversation
rpulkka
changed the title
| @@ -145,7 +145,8 @@ | |||
| </span> | |||
| </ng-template> | |||
| <ng-template let-row="row" #taxonScientificNameLink> | |||
| <a *ngIf="row.scientificName" title="{{row.scientificName}}" [routerLink]="['/taxon/' + row.id] | localize"> | |||
| <a *ngIf="row.scientificName" title="{{row.scientificName}}" | |||
| [routerLink]="['/taxon/' + (row.id.includes('http') ? row.id.split('/').pop() : row.id)] | localize"> | |||
There was a problem hiding this comment.
This is highly suspicious. Why is the id property an url? Sounds like the data needs to be parsed earlier to parse the id out of the url...
There was a problem hiding this comment.
True. I found a code block from species-list.component.ts now which seems to transform ID to url for some reason. I deleted it now, and it doesn't return url from ID anymore.
| @@ -1,9 +1,11 @@ | |||
| <ol class="breadcrumb" *ngIf="informalGroup && informalGroup.id"> | |||
| <li routerLinkActive="active" [routerLinkActiveOptions]="{exact: true}"> | |||
| <a (click)="informalGroupSelect.emit()" tabindex="0" role="button" luKeyboardClickable>{{ 'observation.active.informalTaxonGroupAll' | translate }}</a> | |||
| <a [routerLink]="'/taxon/browse'" (click)="informalGroupSelect.emit()" | |||
There was a problem hiding this comment.
Don't use click events on a elements, this creates a collision with default browser behavior (you can actually visually see some weirdness if you compare how the informal group select behaves on dev.laji.fi vs this branch). The component needs to be refactored to remove the informalGroupSelect event entirely from both informal-list and informal-list-breadcrumb. Instead, add a queryparams change listener, and use that to update the "search query"
There was a problem hiding this comment.
I tried to subscribe to query params now, is it the type of change listener that you meant?
https://696.dev.laji.fi/taxon/browse?informalGroupFilters=MVL.343
#696
Three changes: