Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL, image count, and data source fields to viewer #239 #754

Merged
merged 7 commits into from
Mar 3, 2025

Conversation

mikkohei13
Copy link
Member

@mikkohei13 mikkohei13 commented Feb 27, 2025

luomus/meta#239 Adds three fields to observation viewer. Can be tested with e.g. these documents:

Translations to be done.

My first pull request here, done with help from AI.

@mikkohei13 mikkohei13 requested a review from aorin February 27, 2025 22:09
Copy link
Contributor

@aorin aorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok, found some issues that should be checked, especially if any of these new fields are needed for the local vihko document viewer

@mikkohei13 mikkohei13 requested a review from aorin February 28, 2025 13:45
Copy link
Contributor

@aorin aorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Blodir Blodir added this to the Release 80 milestone Mar 3, 2025
@Blodir Blodir merged commit ca80ec5 into development Mar 3, 2025
1 check passed
@Blodir Blodir deleted the observation-viewer-239 branch March 3, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants