Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan: Change phpstan extensions to read recipes as string #17

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

pprkut
Copy link
Contributor

@pprkut pprkut commented Feb 21, 2025

This fixes issues with having to execute more complex code in recipes that is not relevant to what we need for the extension

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 54.38%. Comparing base (0c37a3b) to head (4382bc4).
Report is 1 commits behind head on release/0.10.x.

Files with missing lines Patch % Lines
.../ConfigServiceLocatorMethodReturnTypeExtension.php 0.00% 14 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/0.10.x      #17      +/-   ##
====================================================
- Coverage             57.05%   54.38%   -2.67%     
- Complexity               71       74       +3     
====================================================
  Files                     5        5              
  Lines                   163      171       +8     
====================================================
  Hits                     93       93              
- Misses                   70       78       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brianstoop brianstoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests

@pprkut
Copy link
Contributor Author

pprkut commented Feb 21, 2025

Missing tests

We never had them. Feel free to write them, but I'm not blocking this fix on needed tests we never had in the first place

@brianstoop
Copy link
Contributor

Missing tests

We never had them. Feel free to write them, but I'm not blocking this fix on needed tests we never had in the first place

I did not know, its a bit annoying that is all over the files changed section. I'm fine with that then

Copy link
Contributor

@brianstoop brianstoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPCS failing otherwise its fine

…han include them

This fixes issues with having to execute more complex code in recipes that is not
relevant to what we need for the extension
Copy link

@pprkut pprkut merged commit 4382bc4 into lunr-php:release/0.10.x Feb 21, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants