-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPStan: Change phpstan extensions to read recipes as string #17
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.10.x #17 +/- ##
====================================================
- Coverage 57.05% 54.38% -2.67%
- Complexity 71 74 +3
====================================================
Files 5 5
Lines 163 171 +8
====================================================
Hits 93 93
- Misses 70 78 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests
src/Lunr/Core/PHPStan/ConfigServiceLocatorMethodReturnTypeExtension.php
Outdated
Show resolved
Hide resolved
94c4dcb
to
6e8c9c4
Compare
We never had them. Feel free to write them, but I'm not blocking this fix on needed tests we never had in the first place |
I did not know, its a bit annoying that is all over the files changed section. I'm fine with that then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPCS failing otherwise its fine
…han include them This fixes issues with having to execute more complex code in recipes that is not relevant to what we need for the extension
6e8c9c4
to
4382bc4
Compare
|
This fixes issues with having to execute more complex code in recipes that is not relevant to what we need for the extension