Smith-Waterman algorithm implementation under Apache 2 #126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #125
Improvements from the previous version of the
alignment.py
:In writing this implementation I decided to respect the signature of the original script to have a drop-in replacement for the algorithm. No additional dependencias were introduced.
The
demo.py
script was run successfullyOptionally I also wrote unit tests on the old script to compare it with my implementation. I could also commit those to maintain consistency in case of future PRs