feat(campaigns): Added support for Campaigns #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin-doyle
commented
Aug 23, 2022
| @@ -3,7 +3,7 @@ | |||
| const ClientVersion = require('../package.json').version; | |||
| const Resources = require('./resources'); | |||
|
|
|||
| const LOB_HOST = 'https://api.lob.com/v1/'; | |||
| const LOB_HOST = process.env.LOB_HOST || 'https://api.lob.com/v1/'; | |||
There was a problem hiding this comment.
I add this so I could test in staging by passing LOB_HOST in when running npm test
…dency conflicts from erroring out
|
I'm not sure why these tests are timing out. I was able to run them locally with all tests passing and 100% coverage of the new code. I wonder if the API key stored in GitHub needs to be updated? |
That's a strong possibility, just updated the key and will re-run. If it fails, will test locally and approve. edit: There's also a sickeningly low threshold for timeout with our API. Tests pass locally 👍 |
BennyKitchell
changed the title
BennyKitchell
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to list, create, retrieve and delete for Campaigns.