fix(bulk): Load IDs from list only when necessary #1574
Merged
+23
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating
changeSets
we are only interested in the diff betweenmatchForm
andtargetForm
and thus we don't need to bother with loading ID lists possibly contained inmatchForm
. Loading ID lists over and over for every call to the bulk preview API is likely the reason for the heap space errors occurring lately.The key fix is to not provide a
Whelk
instance herelibrisxl/housekeeping/src/main/groovy/whelk/housekeeping/BulkChangePreviewAPI.java
Line 97 in e91e02a