Add table view #774
Draft
Add table view #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft because this is somewhat fragile.
position in the virtualized table is handled internally by the table by manually setting a padding_top. So if the caller of a table ever manually sets a padding top, it will break the table. I did this because using a before_node like how the virtual list does breaks the grid layout.
I've also had to hard code in the column headers by painting them in a position that is different from the layout. In order to get this to work without flashing the column headers I had to add a margin top internally to the table.
These hacks wouldn't be necessary if we had layout support in taffy for subgrids and for position: sticky.