Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete reasoning_content in next conversation #14372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

just-wang
Copy link

@just-wang just-wang commented Feb 26, 2025

Summary

DeepSeek's official recommendation is that the thinking content should not be carried over to the next conversation's prompt.
Fixes #13692

Screenshots

Before After
image image

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 26, 2025

import re
def clean_answer(answer):
cleaned_answer = re.sub(r'<details.*?</details>', '', answer, flags=re.DOTALL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually moved this <details.*?</details> out of the backend in new version recently. We only render it in the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

details of deepseek-r1's reasoning_content should not return to model for infer
2 participants