Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement function to truncate json #5811

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Conversation

italojohnny
Copy link
Member

This PR implements a utility function to truncate JSON and applies it to the vertex_build and transaction table fields to ensure consistent formatting of JSON-related data.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #5811 will degrade performances by 21.3%

Comparing feat/json_truncation (8ee5c51) with main (1604526)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 6 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/json_truncation Change
test_build_flow 4,239.2 ms 396.1 ms ×11
test_invalid_run_with_input_type_chat 29.3 ms 25.3 ms +16%
test_successful_run_with_input_type_any 274.8 ms 349.2 ms -21.3%

@italojohnny italojohnny marked this pull request as ready for review January 20, 2025 20:14
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@italojohnny italojohnny enabled auto-merge January 20, 2025 20:15
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
italojohnny and others added 2 commits January 20, 2025 17:37
…s/model.py

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
…s/model.py

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 20, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 20, 2025
@italojohnny italojohnny added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 00dcef2 Jan 20, 2025
33 of 34 checks passed
@italojohnny italojohnny deleted the feat/json_truncation branch January 20, 2025 21:32
@severfire
Copy link

@italojohnny will be those limits applied to json output of the models? like if i ask model to generate json output, will it be truncated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants