Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enhance graph initialization and telemetry handling #5721

Merged
merged 5 commits into from
Jan 20, 2025
Merged

refactor: enhance graph initialization and telemetry handling #5721

merged 5 commits into from
Jan 20, 2025

Conversation

italojohnny
Copy link
Member

This PR implements the change proposed in issue #5580

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 16, 2025
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Jan 16, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 16, 2025
@severfire
Copy link

Hi @italojohnny thanks for great work! Is this fix also related to this issue as well? #5275 Thanks!

@ogabrielluiz
Copy link
Contributor

Hey @severfire
Not yet. I'll fix that one soon.

ogabrielluiz
ogabrielluiz approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

LGTM

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2025
@severfire
Copy link

@ogabrielluiz Awesome, thank you! So soon I will be able to run 25 worker instance :-D

@NadirJ NadirJ self-requested a review January 16, 2025 14:27
@italojohnny italojohnny enabled auto-merge January 16, 2025 14:49
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 17, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 17, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 17, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Jan 20, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 20, 2025

CodSpeed Performance Report

Merging #5721 will degrade performances by 25.28%

Comparing fix/task-cancel-db (fe9d052) with main (69dc960)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/task-cancel-db Change
⚡ test_get_and_cache_all_types_dict 2.2 ms 1.9 ms +17.02%
❌ test_successful_run_with_input_type_any 264 ms 353.4 ms -25.28%

@italojohnny italojohnny added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit d413abb Jan 20, 2025
25 checks passed
@italojohnny italojohnny deleted the fix/task-cancel-db branch January 20, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbornet cbornet cbornet approved these changes

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@NadirJ NadirJ NadirJ approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@italojohnny @severfire @ogabrielluiz @cbornet @NadirJ