Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance Anthropic component UI and validation #5690

Conversation

viniciossilva3
Copy link
Contributor

@viniciossilva3 viniciossilva3 commented Jan 15, 2025

The following improvements were made to the Anthropic component:

  • Made API key field required to ensure proper configuration
  • Replaced FloatInput with SliderInput for temperature parameter to improve user experience
  • Added step control (0.01) for more precise temperature adjustments

This pull request focuses on updating the requirements for inputs in the AnthropicModelComponent and related configurations. The key changes include making the api_key a required input and ensuring that this requirement is reflected in the initial setup for starter projects.

Updates to input requirements:

Changes in initial setup configuration:

The following improvements were made to the Anthropic component:
- Made API key field required to ensure proper configuration
- Replaced FloatInput with SliderInput for temperature parameter to improve user experience
- Added step control (0.01) for more precise temperature adjustments

Co-authored-by: Vinícios Batista da Silva <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Jan 15, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #5690 will degrade performances by 31.27%

Comparing viniciossilva3:feature/anthropic-improvements (fc0fd67) with main (88111c3)

Summary

❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main viniciossilva3:feature/anthropic-improvements Change
test_successful_run_with_input_type_text 175.5 ms 253 ms -30.64%
test_successful_run_with_output_type_debug 173.7 ms 252.7 ms -31.27%

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 15, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 16, 2025
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Could break the agents

Latest updated changes Refer PR: #5720

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jan 16, 2025
@edwinjosechittilappilly
Copy link
Collaborator

Thank you @carlosrcoelho for tagging me!

auto-merge was automatically disabled January 17, 2025 00:43

Head branch was pushed to by a user without write access

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
This change ensures that the Anthropic API key is required for the component to work properly,
preventing potential runtime errors when the key is missing.

Co-authored-by: Vinícios Batista da Silva <[email protected]>
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 17, 2025
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 17, 2025
@edwinjosechittilappilly edwinjosechittilappilly added this pull request to the merge queue Jan 17, 2025
auto-merge was automatically disabled January 17, 2025 23:10

Pull Request is not mergeable

Merged via the queue into langflow-ai:main with commit f4a7d9d Jan 17, 2025
35 of 36 checks passed
@viniciossilva3 viniciossilva3 deleted the feature/anthropic-improvements branch January 28, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants