Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update tweaks processing to allow input_type without input_value #5656

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

anovazzi1
Copy link
Contributor

@anovazzi1 anovazzi1 commented Jan 13, 2025

this pr prevent's a behavior were the tweaks were not applied before even if they were provided and no input value was given

Fixes #5438

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 13, 2025
@dosubot dosubot bot added the bug Something isn't working label Jan 13, 2025
@anovazzi1
Copy link
Contributor Author

anovazzi1 commented Jan 14, 2025

Fixes #5438

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2025
@italojohnny italojohnny enabled auto-merge January 14, 2025 20:56
@italojohnny italojohnny added this pull request to the merge queue Jan 15, 2025
Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #5656 will degrade performances by 25.48%

Comparing fixTweaksWithoutInputValueAPI (3c6e070) with main (a756061)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fixTweaksWithoutInputValueAPI Change
test_successful_run_with_output_type_any 240.5 ms 322.7 ms -25.48%
test_successful_run_with_output_type_debug 248.9 ms 170.6 ms +45.87%

Merged via the queue into main with commit f4fca2b Jan 15, 2025
25 checks passed
@italojohnny italojohnny deleted the fixTweaksWithoutInputValueAPI branch January 15, 2025 20:54
mieslep pushed a commit to mieslep/langflow that referenced this pull request Jan 15, 2025
…langflow-ai#5656)

* fix: tweaks processing in api usage

* refactor code

* fix: unit tests

* Refactor input handling in simple_run_flow function

* Refactor input handling in test_endpoints.py

---------

Co-authored-by: Ítalo Johnny <[email protected]>
ogabrielluiz pushed a commit that referenced this pull request Jan 16, 2025
…#5656)

* fix: tweaks processing in api usage

* refactor code

* fix: unit tests

* Refactor input handling in simple_run_flow function

* Refactor input handling in test_endpoints.py

---------

Co-authored-by: Ítalo Johnny <[email protected]>
viniciossilva3 pushed a commit to viniciossilva3/langflow that referenced this pull request Jan 16, 2025
…langflow-ai#5656)

* fix: tweaks processing in api usage

* refactor code

* fix: unit tests

* Refactor input handling in simple_run_flow function

* Refactor input handling in test_endpoints.py

---------

Co-authored-by: Ítalo Johnny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweaks not passing into Text Input Components via API
2 participants