fix: address api_request issues on Python 3.11+ #5643
Merged
+52
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
github-actions
bot
added
bug
- Enhanced assertion for metadata keys to include raw result in error message for better debugging. - Updated file reading method to use aiofiles for consistency with asynchronous file operations. - Ensured that the test validates the existence and content of saved files accurately.
- Replaced aiofile with aiofiles for consistent asynchronous file operations. - Added logic to ensure parent directories are created before saving files. - Improved file existence check by using exclusive creation mode to handle filename conflicts. - Updated file writing methods to handle both binary and text content appropriately.
github-actions
bot
added
bug
mieslep
added a commit
to mieslep/langflow
that referenced
this pull request
Jan 15, 2025
Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses nightly build failures seen on 3.11 and 3.12 versions.