Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardize node output icons with TextSearch and Chevrons #5600

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

Cristhianzl
Copy link
Member

This pull request includes various updates to the frontend components to improve the UI and functionality. The most important changes include modifications to the NodeInputField and NodeOutputField components, updates to tooltips, and adjustments to the styling of buttons and other elements.

UI and Functionality Improvements:

image

image

image

image

image

…tInput is true for better UI appearance

📝 (NodeOutputfield): Import TextSearch component from lucide-react library for future use
🔧 (RenderInputParameters): Simplify logic for determining lastInput in NodeInputField component
🔧 (GenericNode): Change icon displayed on HiddenOutputsButton based on showHiddenOutputs state
🔧 (GenericNode): Update tooltip content to include the number of hiddenOutputs when toggling visibility
🔧 (sliderComponent): Remove unnecessary padding-bottom from SliderComponent for better layout
📝 (constants.ts): Update tooltip text for better clarity and consistency with action names
@Cristhianzl Cristhianzl self-assigned this Jan 8, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@github-actions github-actions bot added the enhancement New feature or request label Jan 8, 2025
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
…ent to include ForwardedIconComponent for better organization and clarity

🐛 (chatInputOutputUser-shard-0.spec.ts, chatInputOutputUser-shard-1.spec.ts): Fix references to 'ScanEye' icon to 'TextSearchIcon' for consistency and accuracy in tests
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 10, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Jan 10, 2025
@Cristhianzl Cristhianzl added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit febae4b Jan 10, 2025
22 of 30 checks passed
@Cristhianzl Cristhianzl deleted the cz/new-expand-icons branch January 10, 2025 18:40
mieslep pushed a commit to mieslep/langflow that referenced this pull request Jan 15, 2025
…gflow-ai#5600)

* ✨ (NodeInputField): Update styling to include padding-bottom when lastInput is true for better UI appearance
📝 (NodeOutputfield): Import TextSearch component from lucide-react library for future use
🔧 (RenderInputParameters): Simplify logic for determining lastInput in NodeInputField component
🔧 (GenericNode): Change icon displayed on HiddenOutputsButton based on showHiddenOutputs state
🔧 (GenericNode): Update tooltip content to include the number of hiddenOutputs when toggling visibility
🔧 (sliderComponent): Remove unnecessary padding-bottom from SliderComponent for better layout
📝 (constants.ts): Update tooltip text for better clarity and consistency with action names

* ✨ (NodeOutputfield/index.tsx): Update import statement for IconComponent to include ForwardedIconComponent for better organization and clarity
🐛 (chatInputOutputUser-shard-0.spec.ts, chatInputOutputUser-shard-1.spec.ts): Fix references to 'ScanEye' icon to 'TextSearchIcon' for consistency and accuracy in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants