-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardize node output icons with TextSearch and Chevrons #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tInput is true for better UI appearance 📝 (NodeOutputfield): Import TextSearch component from lucide-react library for future use 🔧 (RenderInputParameters): Simplify logic for determining lastInput in NodeInputField component 🔧 (GenericNode): Change icon displayed on HiddenOutputsButton based on showHiddenOutputs state 🔧 (GenericNode): Update tooltip content to include the number of hiddenOutputs when toggling visibility 🔧 (sliderComponent): Remove unnecessary padding-bottom from SliderComponent for better layout 📝 (constants.ts): Update tooltip text for better clarity and consistency with action names
lucaseduoli
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ent to include ForwardedIconComponent for better organization and clarity 🐛 (chatInputOutputUser-shard-0.spec.ts, chatInputOutputUser-shard-1.spec.ts): Fix references to 'ScanEye' icon to 'TextSearchIcon' for consistency and accuracy in tests
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Jan 15, 2025
…gflow-ai#5600) * ✨ (NodeInputField): Update styling to include padding-bottom when lastInput is true for better UI appearance 📝 (NodeOutputfield): Import TextSearch component from lucide-react library for future use 🔧 (RenderInputParameters): Simplify logic for determining lastInput in NodeInputField component 🔧 (GenericNode): Change icon displayed on HiddenOutputsButton based on showHiddenOutputs state 🔧 (GenericNode): Update tooltip content to include the number of hiddenOutputs when toggling visibility 🔧 (sliderComponent): Remove unnecessary padding-bottom from SliderComponent for better layout 📝 (constants.ts): Update tooltip text for better clarity and consistency with action names * ✨ (NodeOutputfield/index.tsx): Update import statement for IconComponent to include ForwardedIconComponent for better organization and clarity 🐛 (chatInputOutputUser-shard-0.spec.ts, chatInputOutputUser-shard-1.spec.ts): Fix references to 'ScanEye' icon to 'TextSearchIcon' for consistency and accuracy in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates to the frontend components to improve the UI and functionality. The most important changes include modifications to the
NodeInputField
andNodeOutputField
components, updates to tooltips, and adjustments to the styling of buttons and other elements.UI and Functionality Improvements:
src/frontend/src/CustomNodes/GenericNode/components/NodeInputField/index.tsx
: Adjusted the padding for the last input element to ensure proper spacing.src/frontend/src/CustomNodes/GenericNode/components/NodeOutputfield/index.tsx
: Replaced theScanEyeIcon
withTextSearch
and imported theTextSearch
component fromlucide-react
. [1] [2]src/frontend/src/CustomNodes/GenericNode/components/RenderInputParameters/index.tsx
: Simplified the condition forlastInput
to improve readability and maintainability.src/frontend/src/CustomNodes/GenericNode/index.tsx
: Updated the button styling and tooltip content for hidden outputs to enhance the user experience. [1] [2]src/frontend/src/constants/constants.ts
: Modified tooltip text for hidden outputs to provide clearer instructions.