fix: the database url is missing ":\\" when sqlite or postgresql is not used #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #5492 will not alter performanceComparing Summary
|
ogabrielluiz
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Hey @qq745639151
Good catch. Please take a look at my comment.
github-actions
bot
added
bug
dosubot
bot
added
size:S
github-actions
bot
added
bug
github-actions
bot
added
bug
ogabrielluiz
pushed a commit
to raphaelchristi/langflow
that referenced
this pull request
Jan 10, 2025
…ot used (langflow-ai#5492) * 【bugfix】 the database url is missing ":\\" * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * [fix] improve the code to make it easier to understand --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Jan 15, 2025
…ot used (langflow-ai#5492) * 【bugfix】 the database url is missing ":\\" * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes * [fix] improve the code to make it easier to understand --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I set the environment varialbe
LANGFLOW_DATABASE_URLstart with "mysql+aiomysql://"， the function_create_enginesplit it to judge the database will be used. But if sqlite or postgresql is not used. the url is missing "://"