Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add useMemo to chatHistory to avoid unecessary renders on Playground #5376

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

Cristhianzl
Copy link
Member

This pull request includes several changes focused on renaming files and updating import paths in the src/frontend/src/modals/IOModal directory. These changes aim to improve the organization and consistency of the codebase. The most important changes include renaming files to follow a consistent naming convention, updating import paths accordingly, and removing an obsolete component.

Renaming files and updating import paths:

Removing obsolete component:

These changes improve the consistency and maintainability of the codebase by ensuring that file names and import paths follow a clear and predictable structure.

@Cristhianzl Cristhianzl self-assigned this Dec 19, 2024
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 19, 2024
@github-actions github-actions bot added the performance Maintenance tasks and housekeeping label Dec 19, 2024
…ssage component and using memoized version for chat history items
@github-actions github-actions bot added performance Maintenance tasks and housekeeping and removed performance Maintenance tasks and housekeeping labels Dec 20, 2024
…e additional props for improved performance and accuracy
@github-actions github-actions bot added performance Maintenance tasks and housekeeping and removed performance Maintenance tasks and housekeeping labels Dec 20, 2024
@github-actions github-actions bot added performance Maintenance tasks and housekeeping and removed performance Maintenance tasks and housekeeping labels Dec 20, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@Cristhianzl Cristhianzl requested review from ogabrielluiz and removed request for ogabrielluiz December 20, 2024 20:10
@github-actions github-actions bot added performance Maintenance tasks and housekeeping and removed performance Maintenance tasks and housekeeping labels Dec 23, 2024
@Cristhianzl Cristhianzl added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 4fec41f Dec 24, 2024
22 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-chat-lag branch December 24, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer performance Maintenance tasks and housekeeping size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants