-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add useMemo to chatHistory to avoid unecessary renders on Playground #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogabrielluiz
requested changes
Dec 20, 2024
src/frontend/src/modals/IOModal/components/chatView/chat-view.tsx
Outdated
Show resolved
Hide resolved
…ssage component and using memoized version for chat history items
ogabrielluiz
requested changes
Dec 20, 2024
src/frontend/src/modals/IOModal/components/chatView/chat-view.tsx
Outdated
Show resolved
Hide resolved
…e additional props for improved performance and accuracy
anovazzi1
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ogabrielluiz
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm
This PR has been approved by a maintainer
performance
Maintenance tasks and housekeeping
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes focused on renaming files and updating import paths in the
src/frontend/src/modals/IOModal
directory. These changes aim to improve the organization and consistency of the codebase. The most important changes include renaming files to follow a consistent naming convention, updating import paths accordingly, and removing an obsolete component.Renaming files and updating import paths:
src/frontend/src/modals/IOModal/components/IOFieldView/components/csv-selected.tsx
: Renamed fromcsvSelect/index.tsx
and updated import paths to reflect the new file structure.src/frontend/src/modals/IOModal/components/IOFieldView/components/file-input.tsx
: Renamed fromFileInput/index.tsx
and updated import paths to reflect the new file structure.src/frontend/src/modals/IOModal/components/IOFieldView/components/json-input.tsx
: Renamed fromJSONInput/index.tsx
and updated import paths to reflect the new file structure.src/frontend/src/modals/IOModal/components/IOFieldView/components/key-pair-input.tsx
: Renamed fromkeyPairInput/index.tsx
and updated import paths to reflect the new file structure.src/frontend/src/modals/IOModal/components/chat-view-wrapper.tsx
: Renamed fromchatViewWrapper/index.tsx
and updated import paths to reflect the new file structure. [1] [2] [3]Removing obsolete component:
src/frontend/src/modals/IOModal/components/IOFieldView/components/sessionSelector/index.tsx
: Removed theSessionSelector
component as it is no longer needed.These changes improve the consistency and maintainability of the codebase by ensuring that file names and import paths follow a clear and predictable structure.