fix: Resolve DOM validation & React lifecycle warnings #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r PopoverTrigger 📝 (frontend): Refactor ShadTooltip component to use forwardRef and add displayName 📝 (frontend): Update AppHeaderComponent to remove unnecessary aria-hidden attribute 📝 (frontend): Refactor SelectOptions component to improve code structure and readability 📝 (frontend): Update SideBarFoldersButtonsComponent to add getRandomKeyByssmm function and improve code structure 📝 (AWS.jsx): Update fill color condition to use stringToBool function for props.isdark 📝 (index.tsx): Convert isdark value to string before passing it to SvgAWS component 📝 (AstraDB.jsx): Update fill color condition to use stringToBool function for props.isdark ✨ (icons): Convert 'isdark' variable to string to ensure consistent type ♻️ (icons): Refactor 'fill-rule' and 'clip-rule' attributes to 'fillRule' and 'clipRule' for consistency ♻️ (nvidia): Refactor 'enable-background' attribute to 'enableBackground' for consistency ♻️ (nvidia): Refactor 'fill' attribute to use 'stringToBool' function for consistent boolean conversion 📝 (utils): Add 'stringToBool' function to convert string to boolean for reusability
dosubot
bot
added
size:L
Cristhianzl
changed the title
github-actions
bot
added
bug
dosubot
bot
added
size:XXL
|
It seems that this implementation broke the notification popup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes fix several console errors.
#5090
Component Enhancements:
src/frontend/src/components/common/shadTooltipComponent/index.tsx: Refactored theShadTooltipcomponent to useforwardReffor better ref handling and added theasChildprop toTooltipTrigger. [1] [2] [3] [4]src/frontend/src/components/core/folderSidebarComponent/components/sideBarFolderButtons/components/select-options.tsx: Updated theSelectOptionscomponent to conditionally render theSelectTriggerbased on thecheckPathNamefunction and removed unnecessary fragments. [1] [2] [3]Icon Component Modifications:
src/frontend/src/icons/AWS/AWS.jsx: Added a utility functionstringToBoolto handle theisdarkprop correctly for dark mode. [1] [2]src/frontend/src/icons/AstraDB/AstraDB.jsx: Applied thestringToBoolfunction to theisdarkprop for dark mode handling. [1] [2]src/frontend/src/icons/Nvidia/nvidia.jsx: Updated theisdarkprop handling using thestringToBoolfunction for dark mode compatibility. [1] [2] [3]These changes ensure better ref handling, conditional rendering, and consistent dark mode behavior across the application.