Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add text-foreground class to NodeStatus build element #5162

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

Cristhianzl
Copy link
Member

@Cristhianzl Cristhianzl commented Dec 9, 2024

This pull request includes a small change to the NodeStatus component in the src/frontend/src/CustomNodes/GenericNode/components/NodeStatus/index.tsx file. The change updates the styling of the STATUS_BUILD element to include the text-foreground class.

Before:
image

Now:
image

…o improve text styling in build status section
@Cristhianzl Cristhianzl self-assigned this Dec 9, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 9, 2024
…lex and text-foreground classes to status elements
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
…' to improve code organization and readability in the NodeStatus component.

📝 (index.tsx): Refactor NodeStatus component to use the new 'BuildStatusDisplay' component for displaying build status, validation details, and last run time. This change enhances code maintainability and reduces duplication.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 9, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) December 9, 2024 20:06
@Cristhianzl Cristhianzl merged commit 240e579 into main Dec 9, 2024
19 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-msg-status branch December 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants