Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove some useless asyncio.to_thread #5149

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Dec 7, 2024

Remove some useless asyncio.to_thread

@cbornet cbornet requested a review from ogabrielluiz December 7, 2024 13:22
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2024
@cbornet cbornet force-pushed the remove-to_thread branch 2 times, most recently from 9e4634d to bcf3381 Compare December 8, 2024 16:23
Copy link

codspeed-hq bot commented Dec 8, 2024

CodSpeed Performance Report

Merging #5149 will degrade performances by 27.18%

Comparing cbornet:remove-to_thread (3fbfb64) with main (0b39554)

Summary

⚡ 4 improvements
❌ 3 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:remove-to_thread Change
test_create_starter_projects 1,263.6 ms 661.8 ms +90.93%
test_get_and_cache_all_types_dict 896.9 µs 1,014.6 µs -11.6%
test_initialize_services 711 ms 154.4 ms ×4.6
test_initialize_super_user 957.7 ms 160.8 ms ×6
test_setup_llm_caching 106.8 ms 1.4 ms ×79
test_successful_run_with_input_type_any 184.9 ms 253.9 ms -27.18%
test_successful_run_with_output_type_any 196.9 ms 243.8 ms -19.24%

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 8, 2024
@cbornet cbornet merged commit c0b25fa into langflow-ai:main Dec 8, 2024
19 checks passed
@cbornet cbornet deleted the remove-to_thread branch December 8, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants