Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: add data test id and improve wait times for element selectors in regression tests #5138

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Refactor: add data test id and improve wait times for element selectors in regression tests #5138

merged 4 commits into from
Dec 9, 2024
+12 −13

Conversation

anovazzi1
Copy link
Contributor

improve test performance

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 6, 2024
@anovazzi1 anovazzi1 requested a review from Cristhianzl December 6, 2024 19:35
Cristhianzl
Cristhianzl approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) December 9, 2024 16:41
@anovazzi1 anovazzi1 merged commit b3e06aa into main Dec 9, 2024
19 checks passed
@anovazzi1 anovazzi1 deleted the generalBugsShard7 branch December 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anovazzi1 @Cristhianzl