Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make chatinput text appear on playground only if no sessions are present #5117

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes a small change to the ChatView component in the newChatView.tsx file. The change modifies a condition to check the messages array instead of finalChatHistory for determining whether to set the chat input value.

Changes to ChatView:

@lucaseduoli lucaseduoli self-assigned this Dec 6, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Dec 6, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 6, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) December 9, 2024 18:31
@Cristhianzl Cristhianzl merged commit dc0291f into main Dec 9, 2024
19 checks passed
@Cristhianzl Cristhianzl deleted the fix/chatinput_playground_session branch December 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants