Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Apply ruff rule TC006 #5088

Merged
merged 2 commits into from
Dec 8, 2024
Merged

ref: Apply ruff rule TC006 #5088

merged 2 commits into from
Dec 8, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Dec 5, 2024 •
edited
Loading

@cbornet cbornet requested a review from ogabrielluiz December 5, 2024 14:51
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 5, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5088 will improve performances by 21.24%

Comparing cbornet:ruff-tc006 (a2f7001) with main (2f0c67e)

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main cbornet:ruff-tc006 Change
⚡ test_get_and_cache_all_types_dict 1,012.3 µs 881.3 µs +14.86%
⚡ test_successful_run_with_input_type_text 252.4 ms 208.2 ms +21.24%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2024
@cbornet cbornet enabled auto-merge (squash) December 8, 2024 11:30
@cbornet cbornet merged commit 60b1927 into langflow-ai:main Dec 8, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @ogabrielluiz