Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add message feedback and update frontend interface #5022

Merged
merged 18 commits into from
Dec 17, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request includes commits that add message feedback and update the frontend interface.

Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #5022 will degrade performances by 53.98%

Comparing evaluateMessage (5b91bec) with main (4be6b04)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main evaluateMessage Change
test_get_and_cache_all_types_dict 1 ms 2.2 ms -53.98%
test_successful_run_with_output_type_any 313.6 ms 217.7 ms +44.08%

@anovazzi1 anovazzi1 marked this pull request as ready for review December 6, 2024 17:37
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 6, 2024
@dosubot dosubot bot added the enhancement New feature or request label Dec 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@italojohnny italojohnny self-requested a review December 12, 2024 19:42
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good_answer is not a good name.

Maybe positive_feedback?

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Dec 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) December 16, 2024 14:24
@anovazzi1 anovazzi1 marked this pull request as draft December 16, 2024 20:38
auto-merge was automatically disabled December 16, 2024 20:38

Pull request was converted to draft

@anovazzi1 anovazzi1 marked this pull request as ready for review December 17, 2024 18:44
@anovazzi1 anovazzi1 enabled auto-merge (squash) December 17, 2024 18:45
@anovazzi1 anovazzi1 merged commit 02fbb45 into main Dec 17, 2024
35 checks passed
@anovazzi1 anovazzi1 deleted the evaluateMessage branch December 17, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants