Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vector RAG flow for Astra DB comp changes #5006

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Dec 2, 2024

This pull request updates the Vector Store RAG template for changes that have been made to the Astra DB Component.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 2, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 2, 2024
@erichare erichare enabled auto-merge (squash) December 2, 2024 19:54
@erichare erichare requested a review from ogabrielluiz December 2, 2024 19:54
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 2, 2024
@erichare erichare merged commit 7a74c01 into main Dec 2, 2024
29 checks passed
@erichare erichare deleted the bugfix-vector-rag-starter branch December 2, 2024 20:11
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #5006 will degrade performances by 23.56%

Comparing bugfix-vector-rag-starter (02f43dc) with main (19d2974)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bugfix-vector-rag-starter Change
test_successful_run_with_input_type_any 325.1 ms 233.4 ms +39.28%
test_successful_run_with_output_type_any 189.9 ms 248.4 ms -23.56%
test_successful_run_with_output_type_debug 232.3 ms 141.2 ms +64.5%

mieslep pushed a commit to mieslep/langflow that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants