-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: narrow version ranges for project dependencies #5005
Conversation
@italojohnny I definitely like this, but just wondering, do you think == is better than ~= in general? Only asking because i thought it kind of makes sense to allow minor version increments, but maybe that still causes dependency resolution issues? |
@erichare, I performed a quick test where I replaced I admit my solution is quite rudimentary, but it solves the problem without considering other factors. |
Probably specifying exact versions is the safest bet anyway 😄 i'll approve! when i worked on the langchain upgrade PR, i switched a lot of |
Using ~= is pretty useful so we don't block other projects but also to grab bug fixes in other projects. It won't be as open as >= so it isn't as problematic. |
5c67996
to
2e72e96
Compare
This PR aims to address the installation issues of the project package via pip. To simplify dependency resolution, the version ranges of dependencies have been replaced with exact versions to avoid conflicts during pip installation.
The package installation has been tested with Python versions 3.10, 3.11, and 3.12.