refactor: Update true/false response methods to return None #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turn None instead of self.message when condition is not met to improve code clarity and consistency
dosubot
bot
added
the
size:XS
…stead of an empty string in certain cases to improve consistency and avoid potential errors
…alse_response methods to allow returning either Message or str for better flexibility and compatibility with different response types.
mieslep
pushed a commit
to mieslep/langflow
that referenced
this pull request
Dec 4, 2024
…-ai#5001) * ♻️ (conditional_router.py): refactor ConditionalRouterComponent to return None instead of self.message when condition is not met to improve code clarity and consistency * 🐛 (conditional_router.py): fix issue where None was being returned instead of an empty string in certain cases to improve consistency and avoid potential errors * ♻️ (conditional_router.py): Update return type of true_response and false_response methods to allow returning either Message or str for better flexibility and compatibility with different response types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
src/backend/base/langflow/components/logic/conditional_router.pyfile, specifically modifying the return values of two methods to returnNoneinstead ofself.message.Changes to return values:
src/backend/base/langflow/components/logic/conditional_router.py: Modified thetrue_responsemethod to returnNoneinstead ofself.message.src/backend/base/langflow/components/logic/conditional_router.py: Modified thefalse_responsemethod to returnNoneinstead ofself.message.