Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update promptModalComponent.spec.ts to use waitForSelector instead of waitForTimeout #4920

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

anovazzi1
Copy link
Contributor

  • Replaced the usage of waitForTimeout with waitForSelector in promptModalComponent.spec.ts to improve reliability and stability of the tests.

…ad of waitForTimeout

- Replaced the usage of waitForTimeout with waitForSelector in promptModalComponent.spec.ts to improve reliability and stability of the tests.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 28, 2024
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 28, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) November 29, 2024 16:50
@anovazzi1 anovazzi1 merged commit fd399e9 into main Nov 29, 2024
18 checks passed
@anovazzi1 anovazzi1 deleted the improvePromptModalTest branch November 29, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants