Refactor: update fileUploadComponent.spec.ts to improve test reliability, performance and readability #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
ogabrielluiz
approved these changes
Nov 26, 2024
anovazzi1
changed the title
ogabrielluiz
force-pushed
the
ImprovefileUploadComponentTest
branch
from
c6712c9 to
6e0af12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a refactoring of the
fileUploadComponent.spec.tsfile to improve the reliability and readability of the tests. The changes include updating the wait conditions in the tests to usewaitForSelectorinstead ofwaitForTimeoutfor better synchronization. Additionally, the expectation for the visibility of a test file has been updated to usetoBeVisibleinstead ofisVisiblefor more accurate results. These changes aim to enhance the overall quality and maintainability of the test suite.